External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-02 09:55:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

storage: fix bogus target in gluster volume xml

Browse Source 
Commit 6cd60b6 was flat out broken - it tried to print into the
wrong variable.  My testing was obviously too cursory (did the
name get a slash added?); valgrind would have caught the error.
Thankfully it didn't hit any release.

Reported by Peter Krempa.

* src/storage/storage_backend_gluster.c
(virStorageBackendGlusterRefreshVol): Fix bogus code.

Signed-off-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Eric Blake 2013-12-18 21:35:35 -07:00
parent 147a3d2487
commit 3a96cebceb
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/storage/storage_backend_gluster.c
View File

@ -227,14 +227,16 @@ virStorageBackendGlusterRefreshVol(virStorageBackendGlusterStatePtr state,
goto cleanup; goto cleanup;
tmp = state->uri->path; tmp = state->uri->path;
if (virAsprintf(&vol->key, "%s%s", state->uri->path, name) < 0) { if (virAsprintf(&state->uri->path, "/%s", vol->key) < 0) {
state->uri->path = tmp; state->uri->path = tmp;
goto cleanup; goto cleanup;
} }
if (!(vol->target.path = virURIFormat(state->uri))) { if (!(vol->target.path = virURIFormat(state->uri))) {
VIR_FREE(state->uri->path);
state->uri->path = tmp; state->uri->path = tmp;
goto cleanup; goto cleanup;
} }
VIR_FREE(state->uri->path);
state->uri->path = tmp; state->uri->path = tmp;
if (S_ISDIR(st->st_mode)) { if (S_ISDIR(st->st_mode)) {