External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-11-10 07:20:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

vshCmddefCheckInternals: Fix listing of missing completers for 'VSH_OT_ARGV'

Browse Source 
Use a switch statement to cover all cases and check for missing
completers for arguments declared as VSH_OT_ARGV.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2024-03-01 12:35:46 +01:00
parent 7abb44f5f7
commit 3b0b43b485
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tools/vsh.c
View File

@ -324,10 +324,24 @@ vshCmddefCheckInternals(vshControl *ctl,
return -1; /* too many options */
}
if (missingCompleters &&
(opt->type == VSH_OT_STRING || opt->type == VSH_OT_DATA) &&
!opt->completer)
virBufferStrcat(&complbuf, opt->name, ", ", NULL);
if (missingCompleters && !opt->completer) {
switch (opt->type) {
case VSH_OT_STRING:
case VSH_OT_DATA:
case VSH_OT_ARGV:
virBufferStrcat(&complbuf, opt->name, ", ", NULL);
break;
case VSH_OT_BOOL:
/* only name is completed */
case VSH_OT_INT:
/* no point in completing numbers */
case VSH_OT_ALIAS:
/* alias is handled in the referenced command */
case VSH_OT_NONE:
break;
}
}
switch (opt->type) {
case VSH_OT_NONE: