mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-24 22:55:23 +00:00
qemu: domain: Check few more fields for when changing disk source
Both disk->src->shared and disk->src->readonly can't be modified when changing disk source for floppy and cdrom drives since both arguments are passed as arguments of the disk rather than the image in qemu. Historically these fields have only two possible values since they are represented as XML thus we need to ignore if user did not provide them and thus we are treating them as false.
This commit is contained in:
parent
a84d604db5
commit
3b3debfb7f
@ -3940,6 +3940,12 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk,
|
||||
return false;
|
||||
}
|
||||
|
||||
/* checks for fields stored in disk->src */
|
||||
/* unfortunately 'readonly' and 'shared' can't be converted to tristate
|
||||
* values thus we need to ignore the check if the new value is 'false' */
|
||||
CHECK_EQ(src->readonly, "readonly", true);
|
||||
CHECK_EQ(src->shared, "shared", true);
|
||||
|
||||
#undef CHECK_EQ
|
||||
|
||||
return true;
|
||||
|
Loading…
Reference in New Issue
Block a user