External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-11 12:25:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

network: add more debugging of firewall chain creation

Browse Source 
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2019-05-22 13:08:13 +01:00
parent 4330d13852
commit 3b66bd9aa1
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/network/bridge_driver_linux.c
View File

@ -45,28 +45,42 @@ static void networkSetupPrivateChains(void)
{
int rc;
VIR_DEBUG("Setting up global firewall chains");
createdChains = false;
rc = iptablesSetupPrivateChains(VIR_FIREWALL_LAYER_IPV4);
if (rc < 0) {
VIR_DEBUG("Failed to create global IPv4 chains: %s",
virGetLastErrorMessage());
errInitV4 = virSaveLastError();
virResetLastError();
} else {
virFreeError(errInitV4);
errInitV4 = NULL;
if (rc)
if (rc) {
VIR_DEBUG("Created global IPv4 chains");
createdChains = true;
} else {
VIR_DEBUG("Global IPv4 chains already exist");
}
}
rc = iptablesSetupPrivateChains(VIR_FIREWALL_LAYER_IPV6);
if (rc < 0) {
VIR_DEBUG("Failed to create global IPv6 chains: %s",
virGetLastErrorMessage());
errInitV6 = virSaveLastError();
virResetLastError();
} else {
virFreeError(errInitV6);
errInitV6 = NULL;
if (rc)
if (rc) {
VIR_DEBUG("Created global IPv6 chains");
createdChains = true;
} else {
VIR_DEBUG("Global IPv6 chains already exist");
}
}
}
@ -95,8 +109,10 @@ void networkPreReloadFirewallRules(bool startup)
* rules will be present. Thus we can safely just tell it
* to always delete from the builin chain
*/
if (startup && createdChains)
if (startup && createdChains) {
VIR_DEBUG("Requesting cleanup of legacy firewall rules");
iptablesSetDeletePrivate(false);
}
}