From 3c97cb2cad96176541d90a9f0ff03741c5692e2f Mon Sep 17 00:00:00 2001 From: Nikolay Shirokovskiy Date: Thu, 7 Jan 2021 16:09:19 +0300 Subject: [PATCH] src: fix resource leak introduced in d4439a6b8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit @tmp that was copied just above is leaked on plain return. The issue is found by Coverity. Patch that inroduced a leak: d4439a6b8 : src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1 Signed-off-by: Nikolay Shirokovskiy Reviewed-by: Daniel P. Berrangé --- src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 2f9081a877..c9f8ffdb56 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3022,7 +3022,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain, ret = VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION); if (ret < 0) - return NULL; + goto done; if (ret) protection = VIR_MIGRATE_CHANGE_PROTECTION;