From 3d13f6abcd9a031c4e1d8c7a592c4c3df38903b4 Mon Sep 17 00:00:00 2001
From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 10 Feb 2022 15:58:12 +0100
Subject: [PATCH] ch_driver: End job properly on failed chDomainCreateXML()

When creating a domain failed, then the virCHDomainObjEndJob()
would be jumped over. Fix this by creating enjob label and fixing
one goto.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>
---
 src/ch/ch_driver.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c
index b023f7e3d3..cd156a222b 100644
--- a/src/ch/ch_driver.c
+++ b/src/ch/ch_driver.c
@@ -228,10 +228,11 @@ chDomainCreateXML(virConnectPtr conn,
         goto cleanup;
 
     if (virCHProcessStart(driver, vm, VIR_DOMAIN_RUNNING_BOOTED) < 0)
-        goto cleanup;
+        goto endjob;
 
     dom = virGetDomain(conn, vm->def->name, vm->def->uuid, vm->def->id);
 
+ endjob:
     virCHDomainObjEndJob(vm);
 
  cleanup: