External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-06 09:55:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

virrandom: Accept "nodedev" driver in virRandomGenerateWWN()

Browse Source 
The virRandomGenerateWWN() is used solely by nodedev driver to
autogenerate WWNN and WWNP when parsing a nodedev XML. Now, the
idea was (at least during monolithic daemon) that depending on
which hypervisor driver called the nodedev XML parsing (and
virRandomGenerateWWN() under the hood) the corresponding OUI is
used (e.g. "001a4a" for the QEMU driver).

But in era of split daemons things are not that easy. We do not
know which hypervisor driver called us. And there might be no
hypervisor driver at all - users are allowed to connect to
individual drivers directly (e.g. "nodedev:///system").

In this case, we can't use proper OUI. Well, do the next best
thing: pick one (QUMRANET_OUI).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Michal Privoznik 2023-07-17 15:05:11 +02:00
parent baeefe0327
commit 3d9e35b837
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/util/virrandom.c
View File

@ -139,7 +139,13 @@ virRandomGenerateWWN(char **wwn,
return -1;
}
if (STREQ(virt_type, "QEMU")) {
/* In case of split daemon we don't really see the hypervisor
* driver that just re-routed the nodedev driver API. There
* might not be any hypervisor driver even. Yet, we have to
* pick OUI. Pick "QEMU". */
if (STREQ(virt_type, "QEMU") ||
STREQ(virt_type, "nodedev")) {
oui = QUMRANET_OUI;
} else if (STREQ(virt_type, "Xen") ||
STREQ(virt_type, "xenlight")) {