External/libvirt
1
0
Fork 0
Code

util: Alter virAuthGet*Path API to check valid callback

Browse Source 
Before trying to call @auth->cb, let's ensure it exists.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
This commit is contained in:
John Ferlan 2018-08-14 10:05:33 -04:00
parent f707935abf
commit 3dc6b00f0d
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/util/virauth.c
View File

@ -175,6 +175,12 @@ virAuthGetUsernamePath(const char *path,
if (auth->credtype[ncred] != VIR_CRED_AUTHNAME) if (auth->credtype[ncred] != VIR_CRED_AUTHNAME)
continue; continue;
if (!auth->cb) {
virReportError(VIR_ERR_INVALID_ARG, "%s",
_("Missing authentication callback"));
return NULL;
}
cred.type = VIR_CRED_AUTHNAME; cred.type = VIR_CRED_AUTHNAME;
cred.prompt = prompt; cred.prompt = prompt;
cred.challenge = hostname; cred.challenge = hostname;
@ -251,6 +257,12 @@ virAuthGetPasswordPath(const char *path,
continue; continue;
} }
if (!auth->cb) {
virReportError(VIR_ERR_INVALID_ARG, "%s",
_("Missing authentication callback"));
return NULL;
}
cred.type = auth->credtype[ncred]; cred.type = auth->credtype[ncred];
cred.prompt = prompt; cred.prompt = prompt;
cred.challenge = hostname; cred.challenge = hostname;