External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-30 21:47:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: Improve HPT feature handling

Browse Source 
Instead of storing separately whether the feature is enabled
or not and what resizing policy should be used, store both of
them in a single place.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
Andrea Bolognani 2018-02-06 14:49:41 +01:00
parent c5a451ef21
commit 3dd1eb3b26
4 changed files with 17 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/conf/domain_conf.c
View File

@ -906,6 +906,7 @@ VIR_ENUM_IMPL(virDomainIOAPIC,
VIR_ENUM_IMPL(virDomainHPTResizing, VIR_ENUM_IMPL(virDomainHPTResizing,
VIR_DOMAIN_HPT_RESIZING_LAST, VIR_DOMAIN_HPT_RESIZING_LAST,
"none",
"enabled", "enabled",
"disabled", "disabled",
"required", "required",
@ -19239,14 +19240,13 @@ virDomainDefParseXML(xmlDocPtr xml,
tmp = virXMLPropString(nodes[i], "resizing"); tmp = virXMLPropString(nodes[i], "resizing");
if (tmp) { if (tmp) {
int value = virDomainHPTResizingTypeFromString(tmp); int value = virDomainHPTResizingTypeFromString(tmp);
if (value < 0) { if (value < 0 || value == VIR_DOMAIN_HPT_RESIZING_NONE) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("Unknown HPT resizing setting: %s"), _("Unknown HPT resizing setting: %s"),
tmp); tmp);
goto error; goto error;
} }
def->hpt_resizing = value; def->features[val] = value;
def->features[val] = VIR_TRISTATE_SWITCH_ON;
VIR_FREE(tmp); VIR_FREE(tmp);
} }
break; break;
@ -21379,16 +21379,13 @@ virDomainDefFeaturesCheckABIStability(virDomainDefPtr src,
break; break;
case VIR_DOMAIN_FEATURE_HPT: case VIR_DOMAIN_FEATURE_HPT:
if (src->features[i] != dst->features[i] || if (src->features[i] != dst->features[i]) {
src->hpt_resizing != dst->hpt_resizing) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("State of feature '%s' differs: " _("State of feature '%s' differs: "
"source: '%s,%s=%s', destination: '%s,%s=%s'"), "source: '%s=%s', destination: '%s=%s'"),
featureName, featureName,
virTristateSwitchTypeToString(src->features[i]), "resizing", virDomainHPTResizingTypeToString(src->features[i]),
"resizing", virDomainHPTResizingTypeToString(src->hpt_resizing), "resizing", virDomainHPTResizingTypeToString(dst->features[i]));
virTristateSwitchTypeToString(dst->features[i]),
"resizing", virDomainHPTResizingTypeToString(dst->hpt_resizing));
return false; return false;
} }
break; break;
@ -26949,10 +26946,11 @@ virDomainDefFormatInternal(virDomainDefPtr def,
break; break;
case VIR_DOMAIN_FEATURE_HPT: case VIR_DOMAIN_FEATURE_HPT:
if (def->features[i] == VIR_TRISTATE_SWITCH_ON) { if (def->features[i] == VIR_DOMAIN_HPT_RESIZING_NONE)
virBufferAsprintf(buf, "<hpt resizing='%s'/>\n", break;
virDomainHPTResizingTypeToString(def->hpt_resizing));
} virBufferAsprintf(buf, "<hpt resizing='%s'/>\n",
virDomainHPTResizingTypeToString(def->features[i]));
break; break;
/* coverity[dead_error_begin] */ /* coverity[dead_error_begin] */

4
src/conf/domain_conf.h
View File

@ -1871,7 +1871,8 @@ typedef enum {
VIR_ENUM_DECL(virDomainIOAPIC); VIR_ENUM_DECL(virDomainIOAPIC);
typedef enum { typedef enum {
VIR_DOMAIN_HPT_RESIZING_ENABLED = 0, VIR_DOMAIN_HPT_RESIZING_NONE = 0,
VIR_DOMAIN_HPT_RESIZING_ENABLED,
VIR_DOMAIN_HPT_RESIZING_DISABLED, VIR_DOMAIN_HPT_RESIZING_DISABLED,
VIR_DOMAIN_HPT_RESIZING_REQUIRED, VIR_DOMAIN_HPT_RESIZING_REQUIRED,
@ -2363,7 +2364,6 @@ struct _virDomainDef {
unsigned int hyperv_spinlocks; unsigned int hyperv_spinlocks;
virGICVersion gic_version; virGICVersion gic_version;
char *hyperv_vendor_id; char *hyperv_vendor_id;
virDomainHPTResizing hpt_resizing;
int apic_eoi; int apic_eoi;
virDomainClockDef clock; virDomainClockDef clock;

4
src/qemu/qemu_command.c
View File

@ -7249,7 +7249,7 @@ qemuBuildMachineCommandLine(virCommandPtr cmd,
} }
} }
if (def->features[VIR_DOMAIN_FEATURE_HPT] == VIR_TRISTATE_SWITCH_ON) { if (def->features[VIR_DOMAIN_FEATURE_HPT] != VIR_DOMAIN_HPT_RESIZING_NONE) {
const char *str; const char *str;
if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_PSERIES_RESIZE_HPT)) { if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_PSERIES_RESIZE_HPT)) {
@ -7259,7 +7259,7 @@ qemuBuildMachineCommandLine(virCommandPtr cmd,
goto cleanup; goto cleanup;
} }
str = virDomainHPTResizingTypeToString(def->hpt_resizing); str = virDomainHPTResizingTypeToString(def->features[VIR_DOMAIN_FEATURE_HPT]);
if (!str) { if (!str) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("Invalid setting for HPT resizing")); _("Invalid setting for HPT resizing"));

2
src/qemu/qemu_domain.c
View File

@ -3333,7 +3333,7 @@ qemuDomainDefValidateFeatures(const virDomainDef *def)
break; break;
case VIR_DOMAIN_FEATURE_HPT: case VIR_DOMAIN_FEATURE_HPT:
if (def->features[i] == VIR_TRISTATE_SWITCH_ON && if (def->features[i] != VIR_DOMAIN_HPT_RESIZING_NONE &&
!qemuDomainIsPSeries(def)) { !qemuDomainIsPSeries(def)) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("The '%s' feature is not supported for " _("The '%s' feature is not supported for "