External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-31 14:07:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Resolve Coverity FORWARD_NULL

Browse Source 
Coverity complains over the [n]values pairing in virQEMUCapsFreeStringList
and rather than make a bunch if "if values" checks prior to calling, by
just adding the values check inside the free function we avoid the chance
that somehow nvalues is > 0, while values == NULL
This commit is contained in:
John Ferlan 2015-05-05 06:59:56 -04:00
parent e7664eedaa
commit 3e4ce35926
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/qemu/qemu_capabilities.c
View File

@ -1702,6 +1702,8 @@ virQEMUCapsFreeStringList(size_t len,
char **values)
{
size_t i;
if (!values)
return;
for (i = 0; i < len; i++)
VIR_FREE(values[i]);
VIR_FREE(values);
@ -1794,7 +1796,7 @@ virQEMUCapsParseDeviceStrObjectProps(const char *str,
ret = nproplist;
cleanup:
if (ret < 0 && proplist)
if (ret < 0)
virQEMUCapsFreeStringList(nproplist, proplist);
return ret;
}