mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-25 15:15:25 +00:00
qemu: Add check for invalid iothread_id in qemuDomainChgIOThread
https://bugzilla.redhat.com/show_bug.cgi?id=1251886
Since iothread_id == 0 is an invalid value for QEMU let's point
that out specifically. For the IOThreadDel code, the failure would
have ended up being a failure to find the IOThread ID; however, for
the IOThreadAdd code - an IOThread 0 was added and that isn't good.
It seems during many reviews/edits to the code the check for
iothread_id = 0 being invalid was lost - it could have originally
been in the API code, but requested to be moved - I cannot remember.
(cherry picked from commit 32c6b1908b
)
This commit is contained in:
parent
4a3bd30e50
commit
3ed4dba49d
@ -6136,6 +6136,12 @@ qemuDomainChgIOThread(virQEMUDriverPtr driver,
|
||||
virDomainDefPtr persistentDef;
|
||||
int ret = -1;
|
||||
|
||||
if (iothread_id == 0) {
|
||||
virReportError(VIR_ERR_INVALID_ARG, "%s",
|
||||
_("invalid value of 0 for iothread_id"));
|
||||
return -1;
|
||||
}
|
||||
|
||||
cfg = virQEMUDriverGetConfig(driver);
|
||||
|
||||
priv = vm->privateData;
|
||||
|
Loading…
Reference in New Issue
Block a user