External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 07:59:00 +00:00
Code

Transform VIR_ERROR into VIR_WARN in detect_scsi_host_caps

Browse Source 
If detect_scsi_host_caps reports errors but keeps libvirtd going on
startup, the user is misled by the error messages. Transforming them
into warning still shows the problems, but indicates this is not fatal.
This commit is contained in:
Cédric Bosdonnat 2014-11-04 15:12:39 +01:00
parent cc06afaca3
commit 4039e22e46
2 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
po/POTFILES.in
View File

@ -92,7 +92,6 @@ src/network/bridge_driver_linux.c
src/network/leaseshelper.c
src/node_device/node_device_driver.c
src/node_device/node_device_hal.c
src/node_device/node_device_linux_sysfs.c
src/node_device/node_device_udev.c
src/nodeinfo.c
src/nwfilter/nwfilter_dhcpsnoop.c

22
src/node_device/node_device_linux_sysfs.c
View File

@ -62,7 +62,7 @@ detect_scsi_host_caps(union _virNodeDevCapData *d)
d->scsi_host.host,
"port_name",
&d->scsi_host.wwpn) < 0) {
VIR_ERROR(_("Failed to read WWPN for host%d"), d->scsi_host.host);
VIR_WARN("Failed to read WWPN for host%d", d->scsi_host.host);
goto cleanup;
}
@ -70,7 +70,7 @@ detect_scsi_host_caps(union _virNodeDevCapData *d)
d->scsi_host.host,
"node_name",
&d->scsi_host.wwnn) < 0) {
VIR_ERROR(_("Failed to read WWNN for host%d"), d->scsi_host.host);
VIR_WARN("Failed to read WWNN for host%d", d->scsi_host.host);
goto cleanup;
}
@ -78,8 +78,8 @@ detect_scsi_host_caps(union _virNodeDevCapData *d)
d->scsi_host.host,
"fabric_name",
&d->scsi_host.fabric_wwn) < 0) {
VIR_ERROR(_("Failed to read fabric WWN for host%d"),
d->scsi_host.host);
VIR_WARN("Failed to read fabric WWN for host%d",
d->scsi_host.host);
goto cleanup;
}
}
@ -91,8 +91,8 @@ detect_scsi_host_caps(union _virNodeDevCapData *d)
d->scsi_host.host,
"max_npiv_vports",
&max_vports) < 0) {
VIR_ERROR(_("Failed to read max_npiv_vports for host%d"),
d->scsi_host.host);
VIR_WARN("Failed to read max_npiv_vports for host%d",
d->scsi_host.host);
goto cleanup;
}
@ -100,22 +100,22 @@ detect_scsi_host_caps(union _virNodeDevCapData *d)
d->scsi_host.host,
"npiv_vports_inuse",
&vports) < 0) {
VIR_ERROR(_("Failed to read npiv_vports_inuse for host%d"),
d->scsi_host.host);
VIR_WARN("Failed to read npiv_vports_inuse for host%d",
d->scsi_host.host);
goto cleanup;
}
if (virStrToLong_i(max_vports, NULL, 10,
&d->scsi_host.max_vports) < 0) {
VIR_ERROR(_("Failed to parse value of max_npiv_vports '%s'"),
VIR_WARN("Failed to parse value of max_npiv_vports '%s'",
max_vports);
goto cleanup;
}
if (virStrToLong_i(vports, NULL, 10,
&d->scsi_host.vports) < 0) {
VIR_ERROR(_("Failed to parse value of npiv_vports_inuse '%s'"),
vports);
VIR_WARN("Failed to parse value of npiv_vports_inuse '%s'",
vports);
goto cleanup;
}
}