External/libvirt
1
0
Fork 0
Code

conf: Fix memory leak in openvzReadFSConf

Browse Source 
Since 1f5deed9, @veid_str has been leaked in the error path.

Found by Coverity.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
John Ferlan 2020-06-16 08:07:08 -04:00 committed by Peter Krempa
parent dd0e292992
commit 40ef01697f
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/openvz/openvz_conf.c
View File

@ -330,7 +330,7 @@ openvzReadFSConf(virDomainDefPtr def,
{ {
int ret; int ret;
virDomainFSDefPtr fs = NULL; virDomainFSDefPtr fs = NULL;
char *veid_str = NULL; g_autofree char *veid_str = NULL;
char *temp = NULL; char *temp = NULL;
const char *param; const char *param;
unsigned long long barrier, limit; unsigned long long barrier, limit;
@ -365,8 +365,6 @@ openvzReadFSConf(virDomainDefPtr def,
fs->type = VIR_DOMAIN_FS_TYPE_MOUNT; fs->type = VIR_DOMAIN_FS_TYPE_MOUNT;
if (!(fs->src->path = virStringReplace(temp, "$VEID", veid_str))) if (!(fs->src->path = virStringReplace(temp, "$VEID", veid_str)))
goto error; goto error;
VIR_FREE(veid_str);
} }
fs->dst = g_strdup("/"); fs->dst = g_strdup("/");