External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 11:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: move setting emulatorpin ahead of monitor showing up

Browse Source 
If VM is configured with many devices(including passthrough devices)
and large memory, libvirtd will take seconds(in the worst case) to
wait for monitor. In this period the qemu process may run on any
PCPU though I intend to pin emulator to the specified PCPU in xml
configuration.

Actually qemu process takes high cpu usage during vm startup.
So this is not the strict CPU isolation in this case.

Signed-off-by: Zhou yimin <zhouyimin@huawei.com>
This commit is contained in:
Zhou yimin 2014-10-16 22:18:48 +08:00 committed by Martin Kletzander
parent 8b9ec18d68
commit 411cea638f
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/qemu/qemu_process.c
View File

@ -4553,6 +4553,14 @@ int qemuProcessStart(virConnectPtr conn,
if (ret == -1) /* The VM failed to start */ if (ret == -1) /* The VM failed to start */
goto cleanup; goto cleanup;
VIR_DEBUG("Setting cgroup for emulator (if required)");
if (qemuSetupCgroupForEmulator(driver, vm, nodemask) < 0)
goto cleanup;
VIR_DEBUG("Setting affinity of emulator threads");
if (qemuProcessSetEmulatorAffinity(vm) < 0)
goto cleanup;
VIR_DEBUG("Waiting for monitor to show up"); VIR_DEBUG("Waiting for monitor to show up");
if (qemuProcessWaitForMonitor(driver, vm, asyncJob, priv->qemuCaps, pos) < 0) if (qemuProcessWaitForMonitor(driver, vm, asyncJob, priv->qemuCaps, pos) < 0)
goto cleanup; goto cleanup;
@ -4588,10 +4596,6 @@ int qemuProcessStart(virConnectPtr conn,
if (qemuSetupCgroupForVcpu(vm) < 0) if (qemuSetupCgroupForVcpu(vm) < 0)
goto cleanup; goto cleanup;
VIR_DEBUG("Setting cgroup for emulator (if required)");
if (qemuSetupCgroupForEmulator(driver, vm, nodemask) < 0)
goto cleanup;
VIR_DEBUG("Setting cgroup for each IOThread (if required)"); VIR_DEBUG("Setting cgroup for each IOThread (if required)");
if (qemuSetupCgroupForIOThreads(vm) < 0) if (qemuSetupCgroupForIOThreads(vm) < 0)
goto cleanup; goto cleanup;
@ -4600,10 +4604,6 @@ int qemuProcessStart(virConnectPtr conn,
if (qemuProcessSetVcpuAffinities(vm) < 0) if (qemuProcessSetVcpuAffinities(vm) < 0)
goto cleanup; goto cleanup;
VIR_DEBUG("Setting affinity of emulator threads");
if (qemuProcessSetEmulatorAffinity(vm) < 0)
goto cleanup;
VIR_DEBUG("Setting affinity of IOThread threads"); VIR_DEBUG("Setting affinity of IOThread threads");
if (qemuProcessSetIOThreadsAffinity(vm) < 0) if (qemuProcessSetIOThreadsAffinity(vm) < 0)
goto cleanup; goto cleanup;