mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-07 09:19:19 +00:00
cmdVcpuPin: Remove dead code
There's this condition: flags & VIR_DOMAIN_AFFECT_CURRENT && virDomainIsActive(dom) which can never be true since VIR_DOMAIN_AFFECT_CURRENT has hardcoded value of zero. Therefore virDomainIsActive() is a dead code. However, the condition could make sense if it is rewritten as the following: !(flags & VIR_DOMAIN_AFFECT_CONFIG) && virDomainIsActive(dom) Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
parent
cd043390ff
commit
416d0e9418
@ -6499,7 +6499,7 @@ cmdVcpuPin(vshControl *ctl, const vshCmd *cmd)
|
|||||||
|
|
||||||
if (got_vcpu && vcpu >= ncpus) {
|
if (got_vcpu && vcpu >= ncpus) {
|
||||||
if (flags & VIR_DOMAIN_AFFECT_LIVE ||
|
if (flags & VIR_DOMAIN_AFFECT_LIVE ||
|
||||||
(flags & VIR_DOMAIN_AFFECT_CURRENT &&
|
(!(flags & VIR_DOMAIN_AFFECT_CONFIG) &&
|
||||||
virDomainIsActive(dom) == 1))
|
virDomainIsActive(dom) == 1))
|
||||||
vshError(ctl,
|
vshError(ctl,
|
||||||
_("vcpu %d is out of range of live cpu count %d"),
|
_("vcpu %d is out of range of live cpu count %d"),
|
||||||
|
Loading…
Reference in New Issue
Block a user