External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-04 20:15:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

client rpc: Drop unused return value of virNetClientSendNonBlock

Browse Source 
As we never drop non-blocking calls, the return value that used to
indicate a call was dropped is no longer needed.
(cherry picked from commit ca9b13e373)
This commit is contained in:
Jiri Denemark 2012-06-08 15:24:06 +02:00 committed by Cole Robinson
parent 4779cf0ff5
commit 419cb87283
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/rpc/virnetclient.c
View File

@ -1246,8 +1246,8 @@ virNetClientIOEventLoopPassTheBuck(virNetClientPtr client,
* get a reply to our own call. Then quit and pass the buck * get a reply to our own call. Then quit and pass the buck
* to someone else. * to someone else.
* *
* Returns 2 if fully sent, 1 if partially sent (only for nonBlock==true), * Returns 1 if the call was queued and will be completed later (only
* 0 if nothing sent (only for nonBlock==true) and -1 on error * for nonBlock==true), 0 if the call was completed and -1 on error.
*/ */
static int virNetClientIOEventLoop(virNetClientPtr client, static int virNetClientIOEventLoop(virNetClientPtr client,
virNetClientCallPtr thiscall) virNetClientCallPtr thiscall)
@ -1371,7 +1371,7 @@ static int virNetClientIOEventLoop(virNetClientPtr client,
if (thiscall->mode == VIR_NET_CLIENT_MODE_COMPLETE) { if (thiscall->mode == VIR_NET_CLIENT_MODE_COMPLETE) {
virNetClientCallRemove(&client->waitDispatch, thiscall); virNetClientCallRemove(&client->waitDispatch, thiscall);
virNetClientIOEventLoopPassTheBuck(client, thiscall); virNetClientIOEventLoopPassTheBuck(client, thiscall);
return 2; return 0;
} }
/* We're not done, but we're non-blocking; keep the call queued */ /* We're not done, but we're non-blocking; keep the call queued */
@ -1478,8 +1478,8 @@ static void virNetClientIOUpdateCallback(virNetClientPtr client,
* *
* NB(7) Don't Panic! * NB(7) Don't Panic!
* *
* Returns 2 if fully sent, 1 if partially sent (only for nonBlock==true), * Returns 1 if the call was queued and will be completed later (only
* 0 if nothing sent (only for nonBlock==true) and -1 on error * for nonBlock==true), 0 if the call was completed and -1 on error.
*/ */
static int virNetClientIO(virNetClientPtr client, static int virNetClientIO(virNetClientPtr client,
virNetClientCallPtr thiscall) virNetClientCallPtr thiscall)
@ -1537,7 +1537,7 @@ static int virNetClientIO(virNetClientPtr client,
* our reply * our reply
*/ */
if (thiscall->mode == VIR_NET_CLIENT_MODE_COMPLETE) { if (thiscall->mode == VIR_NET_CLIENT_MODE_COMPLETE) {
rv = 2; rv = 0;
/* /*
* We avoided catching the buck and our reply is ready ! * We avoided catching the buck and our reply is ready !
* We've already had 'thiscall' removed from the list * We've already had 'thiscall' removed from the list
@ -1631,8 +1631,8 @@ done:
/* /*
* Returns 2 if fully sent, 1 if queued (only for nonBlock==true), * Returns 1 if the call was queued and will be completed later (only
* 0 if nothing sent (only for nonBlock==true) and -1 on error * for nonBlock==true), 0 if the call was completed and -1 on error.
*/ */
static int virNetClientSendInternal(virNetClientPtr client, static int virNetClientSendInternal(virNetClientPtr client,
virNetMessagePtr msg, virNetMessagePtr msg,
@ -1757,7 +1757,8 @@ int virNetClientSendNoReply(virNetClientPtr client,
* The caller is responsible for free'ing @msg, *except* if * The caller is responsible for free'ing @msg, *except* if
* this method returns 1. * this method returns 1.
* *
* Returns 2 on full send, 1 on partial send, 0 on no send, -1 on error * Returns 1 if the message was queued and will be completed later (only
* for nonBlock==true), 0 if the message was completed and -1 on error.
*/ */
int virNetClientSendNonBlock(virNetClientPtr client, int virNetClientSendNonBlock(virNetClientPtr client,
virNetMessagePtr msg) virNetMessagePtr msg)