External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Remove empty functions

Browse Source 
After previous cleanup, there are some functions that do nothing:

  qemuConnectDomainXMLToNativePrepareHostHostdev()
  qemuConnectDomainXMLToNativePrepareHost()
  qemuProcessPrepareHostHostdev()
  qemuProcessPrepareHostHostdevs()

Remove them.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Michal Privoznik 2023-04-14 13:12:45 +02:00
parent fea0d8c40d
commit 430fc2ec26
4 changed files with 0 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/qemu/qemu_driver.c
View File

@ -6165,29 +6165,6 @@ static char
} }
static int
qemuConnectDomainXMLToNativePrepareHostHostdev(virDomainHostdevDef *hostdev G_GNUC_UNUSED)
{
return 0;
}
static int
qemuConnectDomainXMLToNativePrepareHost(virDomainObj *vm)
{
size_t i;
for (i = 0; i < vm->def->nhostdevs; i++) {
virDomainHostdevDef *hostdev = vm->def->hostdevs[i];
if (qemuConnectDomainXMLToNativePrepareHostHostdev(hostdev) < 0)
return -1;
}
return 0;
}
static char *qemuConnectDomainXMLToNative(virConnectPtr conn, static char *qemuConnectDomainXMLToNative(virConnectPtr conn,
const char *format, const char *format,
const char *xmlData, const char *xmlData,
@ -6244,9 +6221,6 @@ static char *qemuConnectDomainXMLToNative(virConnectPtr conn,
VIR_QEMU_PROCESS_START_COLD) < 0) VIR_QEMU_PROCESS_START_COLD) < 0)
return NULL; return NULL;
if (qemuConnectDomainXMLToNativePrepareHost(vm) < 0)
return NULL;
if (!(cmd = qemuProcessCreatePretendCmdBuild(vm, NULL))) if (!(cmd = qemuProcessCreatePretendCmdBuild(vm, NULL)))
return NULL; return NULL;

3
src/qemu/qemu_hotplug.c
View File

@ -2475,9 +2475,6 @@ qemuDomainAttachHostSCSIDevice(virQEMUDriver *driver,
qemuAssignDeviceHostdevAlias(vm->def, &hostdev->info->alias, -1); qemuAssignDeviceHostdevAlias(vm->def, &hostdev->info->alias, -1);
if (qemuProcessPrepareHostHostdev(hostdev) < 0)
goto cleanup;
if (!(data = qemuBuildHostdevSCSIAttachPrepare(hostdev, &backendalias, if (!(data = qemuBuildHostdevSCSIAttachPrepare(hostdev, &backendalias,
priv->qemuCaps))) priv->qemuCaps)))
goto cleanup; goto cleanup;

27
src/qemu/qemu_process.c
View File

@ -6509,29 +6509,6 @@ qemuProcessPrepareDomainHostdevs(virDomainObj *vm,
} }
int
qemuProcessPrepareHostHostdev(virDomainHostdevDef *hostdev G_GNUC_UNUSED)
{
return 0;
}
static int
qemuProcessPrepareHostHostdevs(virDomainObj *vm)
{
size_t i;
for (i = 0; i < vm->def->nhostdevs; i++) {
virDomainHostdevDef *hostdev = vm->def->hostdevs[i];
if (qemuProcessPrepareHostHostdev(hostdev) < 0)
return -1;
}
return 0;
}
/** /**
* qemuProcessRebootAllowed: * qemuProcessRebootAllowed:
* @def: domain definition * @def: domain definition
@ -7233,10 +7210,6 @@ qemuProcessPrepareHost(virQEMUDriver *driver,
if (qemuProcessPrepareHostStorage(driver, vm, flags) < 0) if (qemuProcessPrepareHostStorage(driver, vm, flags) < 0)
return -1; return -1;
VIR_DEBUG("Preparing hostdevs (host-side)");
if (qemuProcessPrepareHostHostdevs(vm) < 0)
return -1;
VIR_DEBUG("Preparing external devices"); VIR_DEBUG("Preparing external devices");
if (qemuExtDevicesPrepareHost(driver, vm) < 0) if (qemuExtDevicesPrepareHost(driver, vm) < 0)
return -1; return -1;

3
src/qemu/qemu_process.h
View File

@ -111,9 +111,6 @@ int qemuProcessPrepareDomain(virQEMUDriver *driver,
int qemuProcessOpenVhostVsock(virDomainVsockDef *vsock); int qemuProcessOpenVhostVsock(virDomainVsockDef *vsock);
int qemuProcessPrepareHostHostdev(virDomainHostdevDef *hostdev);
int qemuProcessPrepareHostBackendChardevHotplug(virDomainObj *vm, int qemuProcessPrepareHostBackendChardevHotplug(virDomainObj *vm,
virDomainDeviceDef *dev) virDomainDeviceDef *dev)
G_NO_INLINE; G_NO_INLINE;