External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-24 14:45:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix DMI uuid parsing.

Browse Source 
valgrind was complaining that virUUIDParse was depending on
an uninitialized value.  Indeed it was; virSetHostUUIDStr()
didn't initialize the dmiuuid buffer to 0's, meaning that
anything after the string read from /sys was uninitialized.
Clear out the dmiuuid buffer before use, and make sure to
always leave a \0 at the end.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
This commit is contained in:
Chris Lalancette 2010-07-30 10:19:51 -04:00
parent e7da872294
commit 435fa6d709
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/util/uuid.c
View File

@ -286,7 +286,8 @@ virSetHostUUIDStr(const char *uuid)
return EEXIST; return EEXIST;
if (!uuid) { if (!uuid) {
if (!getDMISystemUUID(dmiuuid, sizeof(dmiuuid))) { memset(dmiuuid, 0, sizeof(dmiuuid));
if (!getDMISystemUUID(dmiuuid, sizeof(dmiuuid) - 1)) {
if (!virUUIDParse(dmiuuid, host_uuid)) if (!virUUIDParse(dmiuuid, host_uuid))
return 0; return 0;
} }