From 43cc9b001138310bb6df8964c65abdfc1b59cb0c Mon Sep 17 00:00:00 2001 From: Boris Fiuczynski Date: Thu, 10 Dec 2020 18:32:36 +0100 Subject: [PATCH] node_device: pacify grumpy coverity due to addr override With commit 09364608b4 node_device: refactor address retrieval of node device "if-else if" was replaced by "switch". The contained break statement now is no longer in context of the for loop but instead of the switch causing the legitimate grumpiness of coverity. Signed-off-by: Boris Fiuczynski Suggested-by: John Ferlan Signed-off-by: Michal Privoznik Reviewed-by: Michal Privoznik --- src/node_device/node_device_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index e254b49244..51b20848ce 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -687,6 +687,9 @@ nodeDeviceFindAddressByName(const char *name) case VIR_NODE_DEV_CAP_LAST: break; } + + if (addr) + break; } virNodeDeviceObjEndAPI(&dev);