External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 21:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: don't print error info when snapshot xml is not changed

Browse Source 
If xml is not changed, error message is printed.
So check ret value instead of edit variable for error message.
This commit is contained in:
Guannan Ren 2012-08-22 04:37:34 +08:00
parent 66473616c8
commit 44574a8789
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/virsh-snapshot.c
View File

@ -449,7 +449,7 @@ cmdSnapshotEdit(vshControl *ctl, const vshCmd *cmd)
_("Snapshot %s XML configuration not changed.\n"), \ _("Snapshot %s XML configuration not changed.\n"), \
name); \ name); \
ret = true; \ ret = true; \
goto cleanup; \ goto edit_cleanup; \
} }
#define EDIT_DEFINE \ #define EDIT_DEFINE \
(strstr(doc, "<state>disk-snapshot</state>") ? \ (strstr(doc, "<state>disk-snapshot</state>") ? \
@ -487,10 +487,10 @@ cmdSnapshotEdit(vshControl *ctl, const vshCmd *cmd)
ret = true; ret = true;
cleanup: cleanup:
if (!ret)
vshError(ctl, _("Failed to update %s"), name);
if (edited) if (edited)
virDomainSnapshotFree(edited); virDomainSnapshotFree(edited);
else
vshError(ctl, _("Failed to update %s"), name);
if (snapshot) if (snapshot)
virDomainSnapshotFree(snapshot); virDomainSnapshotFree(snapshot);
if (dom) if (dom)