External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-11 15:27:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: Fix virNodeDeviceObjGetNames nnames increment

Browse Source 
To be safer, only increment nnames after the VIR_STRDUP is successful.
This commit is contained in:
John Ferlan 2017-04-10 08:33:08 -04:00
parent fd6e3f48ed
commit 44d3db9785
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/conf/virnodedeviceobj.c
View File

@ -512,10 +512,11 @@ virNodeDeviceObjGetNames(virNodeDeviceObjListPtr devs,
virNodeDeviceObjLock(obj); virNodeDeviceObjLock(obj);
if (aclfilter && aclfilter(conn, obj->def) && if (aclfilter && aclfilter(conn, obj->def) &&
(!cap || virNodeDeviceObjHasCap(obj, cap))) { (!cap || virNodeDeviceObjHasCap(obj, cap))) {
if (VIR_STRDUP(names[nnames++], obj->def->name) < 0) { if (VIR_STRDUP(names[nnames], obj->def->name) < 0) {
virNodeDeviceObjUnlock(obj); virNodeDeviceObjUnlock(obj);
goto failure; goto failure;
} }
nnames++;
} }
virNodeDeviceObjUnlock(obj); virNodeDeviceObjUnlock(obj);
} }