diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index 212089520d..50c0c4ecc8 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -821,8 +821,6 @@ int virNetSocketNewConnectCommand(virCommand *cmd, if (!(*retsock = virNetSocketNew(NULL, NULL, true, sv[0], errfd[0], pid, false))) goto error; - virCommandFree(cmd); - return 0; error: @@ -832,7 +830,6 @@ int virNetSocketNewConnectCommand(virCommand *cmd, VIR_FORCE_CLOSE(errfd[1]); virCommandAbort(cmd); - virCommandFree(cmd); return -1; } @@ -856,7 +853,7 @@ int virNetSocketNewConnectSSH(const char *nodename, const char *command, virNetSocket **retsock) { - virCommand *cmd; + g_autoptr(virCommand) cmd = NULL; *retsock = NULL; @@ -1154,7 +1151,7 @@ virNetSocketNewConnectLibssh(const char *host G_GNUC_UNUSED, int virNetSocketNewConnectExternal(const char **cmdargv, virNetSocket **retsock) { - virCommand *cmd; + g_autoptr(virCommand) cmd = NULL; *retsock = NULL; diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c index d24baa9a5c..33b8755ab7 100644 --- a/tests/virnetsockettest.c +++ b/tests/virnetsockettest.c @@ -388,7 +388,8 @@ static int testSocketCommandNormal(const void *data G_GNUC_UNUSED) char buf[100]; size_t i; int ret = -1; - virCommand *cmd = virCommandNewArgList("/bin/cat", "/dev/zero", NULL); + g_autoptr(virCommand) cmd = virCommandNewArgList("/bin/cat", "/dev/zero", NULL); + virCommandAddEnvPassCommon(cmd); if (virNetSocketNewConnectCommand(cmd, &csock) < 0) @@ -415,7 +416,8 @@ static int testSocketCommandFail(const void *data G_GNUC_UNUSED) virNetSocket *csock = NULL; /* Client socket */ char buf[100]; int ret = -1; - virCommand *cmd = virCommandNewArgList("/bin/cat", "/dev/does-not-exist", NULL); + g_autoptr(virCommand) cmd = virCommandNewArgList("/bin/cat", "/dev/does-not-exist", NULL); + virCommandAddEnvPassCommon(cmd); if (virNetSocketNewConnectCommand(cmd, &csock) < 0)