From 454f739f24a936aedec48c3a3ba659b374ce251a Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Tue, 26 Apr 2016 12:47:42 -0400 Subject: [PATCH] conf: network: reject name containing '/' Trying to define a network name containing an embedded '/' will immediately fail when trying to write the XML to disk. This patch explicitly rejects names containing a '/' Besides the network bridge driver, the only other network implementation is a very thin one for virtualbox, which seems to use the network name as a host interface name, which won't accept '/' anyways, so I think this is fine to do unconitionally. https://bugzilla.redhat.com/show_bug.cgi?id=787604 --- src/conf/network_conf.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index c574b01b71..48f39c7540 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -2070,6 +2070,12 @@ virNetworkDefParseXML(xmlXPathContextPtr ctxt) goto error; } + if (strchr(def->name, '/')) { + virReportError(VIR_ERR_XML_ERROR, + _("name %s cannot contain '/'"), def->name); + goto error; + } + /* Extract network uuid */ tmp = virXPathString("string(./uuid[1])", ctxt); if (!tmp) {