External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: Set defaultFormat if no storage source XML present

Browse Source 
While parsing if the storage source is not present, then a defaultFormat
was not set. This could lead to oddities such as seeing "unknown" format
in output for the "logical" pool even though the only format the pool could
support would be "lvm2".

This does "put a label" on other pool defaults as follows:

   File System: FS_AUTO
   Network File System: NETFS_AUTO
   Disk: UNKNOWN

Each of which is the "0" value for their respective pools and thus
would be no "real" change.
This commit is contained in:
John Ferlan 2017-03-27 13:01:56 -04:00
parent 03eeb84fed
commit 4572843d4a
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/conf/storage_conf.c
View File

@ -703,6 +703,9 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt)
if (virStoragePoolDefParseSource(ctxt, &ret->source, ret->type, if (virStoragePoolDefParseSource(ctxt, &ret->source, ret->type,
source_node) < 0) source_node) < 0)
goto error; goto error;
} else {
if (options->formatFromString)
ret->source.format = options->defaultFormat;
} }
ret->name = virXPathString("string(./name)", ctxt); ret->name = virXPathString("string(./name)", ctxt);