From 45a84971fb857443c2a6dbb89b6dde41dc6912bc Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 24 Nov 2020 08:04:36 +0100 Subject: [PATCH] qemu: migration: Remove TODO about implementing NBD for TUNNELLED migration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Our streams are not the best transport for migration data and we support TLS for security now. It's unlikely that there will be enough motivation to add a new migration protocol to tunnel NBD too. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_migration.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index fef0be63a1..85f3c4ccee 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2244,10 +2244,7 @@ qemuMigrationSrcBeginPhase(virQEMUDriverPtr driver, } } - /* TODO support NBD for TUNNELLED migration */ - if (flags & VIR_MIGRATE_TUNNELLED) { - VIR_WARN("NBD in tunnelled migration is currently not supported"); - } else { + if (!(flags & VIR_MIGRATE_TUNNELLED)) { cookieFlags |= QEMU_MIGRATION_COOKIE_NBD; priv->nbdPort = 0; }