External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-15 00:55:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't check validity of missing attributes in DNS SRV XML

Browse Source 
This fixes a crash if one of them is missing.

https://bugzilla.redhat.com/show_bug.cgi?id=988718
This commit is contained in:
Ján Tomko 2013-07-26 12:11:21 +02:00
parent c4e23388e6
commit 461fd86a66
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/conf/network_conf.c
View File

@ -920,7 +920,7 @@ virNetworkDNSSrvDefParseXML(const char *networkName,
" of network %s"), networkName); " of network %s"), networkName);
goto error; goto error;
} }
if (strlen(def->service) > DNS_RECORD_LENGTH_SRV) { if (def->service && strlen(def->service) > DNS_RECORD_LENGTH_SRV) {
virReportError(VIR_ERR_XML_DETAIL, virReportError(VIR_ERR_XML_DETAIL,
_("Service name '%s' in network %s is too long, limit is %d bytes"), _("Service name '%s' in network %s is too long, limit is %d bytes"),
def->service, networkName, DNS_RECORD_LENGTH_SRV); def->service, networkName, DNS_RECORD_LENGTH_SRV);
@ -936,7 +936,8 @@ virNetworkDNSSrvDefParseXML(const char *networkName,
} }
/* Check whether protocol value is the supported one */ /* Check whether protocol value is the supported one */
if (STRNEQ(def->protocol, "tcp") && (STRNEQ(def->protocol, "udp"))) { if (def->protocol && STRNEQ(def->protocol, "tcp") &&
(STRNEQ(def->protocol, "udp"))) {
virReportError(VIR_ERR_XML_DETAIL, virReportError(VIR_ERR_XML_DETAIL,
_("Invalid protocol attribute value '%s' " _("Invalid protocol attribute value '%s' "
" in DNS SRV record of network %s"), " in DNS SRV record of network %s"),