External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-31 10:05:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

virt-host-validate: warn if kvm_hv is not loaded for POWER hosts

Browse Source 
POWER hosts does not implement CPU virtualization extensions like
x86 or s390x. Instead, all bare-metal POWER hosts are considered
to be virtualization ready.

For POWER, the validation is done by checking if the virtualization
module kvm_hv is loaded in the host. If not, we should warn the
user about it.

Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Daniel Henrique Barboza 2020-03-13 14:48:03 -03:00 committed by Michal Privoznik
parent 1cf2f412ed
commit 4653a5194c
3 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
tools/virt-host-validate-common.c
View File

@ -412,3 +412,30 @@ int virHostValidateIOMMU(const char *hvname,
virHostMsgPass();
return 0;
}
bool virHostKernelModuleIsLoaded(const char *module)
{
FILE *fp;
bool ret = false;
if (!(fp = fopen("/proc/modules", "r")))
return false;
do {
char line[1024];
if (!fgets(line, sizeof(line), fp))
break;
if (STRPREFIX(line, module)) {
ret = true;
break;
}
} while (1);
VIR_FORCE_FCLOSE(fp);
return ret;
}

2
tools/virt-host-validate-common.h
View File

@ -82,3 +82,5 @@ int virHostValidateCGroupControllers(const char *hvname,
int virHostValidateIOMMU(const char *hvname,
virHostValidateLevel level);
bool virHostKernelModuleIsLoaded(const char *module);

15
tools/virt-host-validate-qemu.c
View File

@ -57,6 +57,11 @@ int virHostValidateQEMU(void)
if (virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_SIE))
hasHwVirt = true;
break;
case VIR_ARCH_PPC64:
case VIR_ARCH_PPC64LE:
hasVirtFlag = true;
hasHwVirt = true;
break;
default:
hasHwVirt = false;
}
@ -84,6 +89,16 @@ int virHostValidateQEMU(void)
ret = -1;
}
if (arch == VIR_ARCH_PPC64 || arch == VIR_ARCH_PPC64LE) {
virHostMsgCheck("QEMU", "%s", _("for PowerPC KVM module loaded"));
if (!virHostKernelModuleIsLoaded("kvm_hv"))
virHostMsgFail(VIR_HOST_VALIDATE_WARN,
_("Load kvm_hv for better performance"));
else
virHostMsgPass();
}
virBitmapFree(flags);
if (virHostValidateDeviceExists("QEMU", "/dev/vhost-net",