External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-10 14:57:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: virNetDevBandwidthClear: use g_auto

Browse Source 
Separate the two uses of 'cmd' to avoid mixing manual and automatic
cleanup.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Ján Tomko 2022-01-17 18:02:31 +01:00
parent e1470a2295
commit 470987a53f
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/util/virnetdevbandwidth.c
View File

@ -416,27 +416,24 @@ virNetDevBandwidthClear(const char *ifname)
{
int ret = 0;
int dummy; /* for ignoring the exit status */
virCommand *cmd = NULL;
g_autoptr(virCommand) rootcmd = NULL;
g_autoptr(virCommand) ingresscmd = NULL;
if (!ifname)
return 0;
cmd = virCommandNew(TC);
virCommandAddArgList(cmd, "qdisc", "del", "dev", ifname, "root", NULL);
rootcmd = virCommandNew(TC);
virCommandAddArgList(rootcmd, "qdisc", "del", "dev", ifname, "root", NULL);
if (virCommandRun(cmd, &dummy) < 0)
if (virCommandRun(rootcmd, &dummy) < 0)
ret = -1;
virCommandFree(cmd);
ingresscmd = virCommandNew(TC);
virCommandAddArgList(ingresscmd, "qdisc", "del", "dev", ifname, "ingress", NULL);
cmd = virCommandNew(TC);
virCommandAddArgList(cmd, "qdisc", "del", "dev", ifname, "ingress", NULL);
if (virCommandRun(cmd, &dummy) < 0)
if (virCommandRun(ingresscmd, &dummy) < 0)
ret = -1;
virCommandFree(cmd);
return ret;
}