External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 04:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: add error checking of UUID generation

Browse Source 
Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2019-06-18 18:36:52 +01:00
parent 520f5752be
commit 473d2eba04
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/conf/domain_conf.c
View File

@ -30415,7 +30415,11 @@ virDomainNetDefToNetworkPort(virDomainDefPtr dom,
if (VIR_ALLOC(port) < 0) if (VIR_ALLOC(port) < 0)
return NULL; return NULL;
virUUIDGenerate(port->uuid); if (virUUIDGenerate(port->uuid) < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR,
"%s", _("Failed to generate UUID"));
goto error;
}
memcpy(port->owneruuid, dom->uuid, VIR_UUID_BUFLEN); memcpy(port->owneruuid, dom->uuid, VIR_UUID_BUFLEN);
if (VIR_STRDUP(port->ownername, dom->name) < 0) if (VIR_STRDUP(port->ownername, dom->name) < 0)
@ -30576,7 +30580,11 @@ virDomainNetDefActualToNetworkPort(virDomainDefPtr dom,
return NULL; return NULL;
/* Bad - we need to preserve original port uuid */ /* Bad - we need to preserve original port uuid */
virUUIDGenerate(port->uuid); if (virUUIDGenerate(port->uuid) < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR,
"%s", _("Failed to generate UUID"));
goto error;
}
memcpy(port->owneruuid, dom->uuid, VIR_UUID_BUFLEN); memcpy(port->owneruuid, dom->uuid, VIR_UUID_BUFLEN);
if (VIR_STRDUP(port->ownername, dom->name) < 0) if (VIR_STRDUP(port->ownername, dom->name) < 0)