From 47a4c0fa0bbda4fbb98ee0131dedf7b465723bb9 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 3 Mar 2008 13:14:26 +0000 Subject: [PATCH] Plug virCapabilities*GuestDomain leak. * src/capabilities.c (virCapabilitiesFreeGuestDomain): Free dom->type. (virCapabilitiesAddGuestDomain): Remove duplicate strdup stmt. --- ChangeLog | 6 ++++++ src/capabilities.c | 4 +--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 049f515d5b..2d54e8a83a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +Mon Mar 3 14:14:03 CET 2008 Jim Meyering + + Plug virCapabilities*GuestDomain leak. + * src/capabilities.c (virCapabilitiesFreeGuestDomain): Free dom->type. + (virCapabilitiesAddGuestDomain): Remove duplicate strdup stmt. + Mon Mar 3 07:16:35 CET 2008 Daniel Veillard * include/libvirt/libvirt.h include/libvirt/libvirt.h.in: diff --git a/src/capabilities.c b/src/capabilities.c index 263935cf50..2544bd36ec 100644 --- a/src/capabilities.c +++ b/src/capabilities.c @@ -73,6 +73,7 @@ virCapabilitiesFreeGuestDomain(virCapsGuestDomainPtr dom) for (i = 0 ; i < dom->info.nmachines ; i++) free(dom->info.machines[i]); free(dom->info.machines); + free(dom->type); free(dom); } @@ -328,9 +329,6 @@ virCapabilitiesAddGuestDomain(virCapsGuestPtr guest, if ((dom->type = strdup(hvtype)) == NULL) goto no_memory; - if ((dom->type = strdup(hvtype)) == NULL) - goto no_memory; - if (emulator && (dom->info.emulator = strdup(emulator)) == NULL) goto no_memory;