External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-11 12:25:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

ch: virCHProcessSetupIOThreads: use correct type for return value

Browse Source 
virCHMonitorGetIOThreads returns an int, not size_t.

Also return early if it's negative, because promoting it to
an unsigned type in the for loop condition could lead to
an infinte loop.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
This commit is contained in:
Ján Tomko 2022-02-02 17:26:48 +01:00
parent 7b1c1642b1
commit 47d194139c
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ch/ch_process.c
View File

@ -327,9 +327,11 @@ virCHProcessSetupIOThreads(virDomainObj *vm)
virCHDomainObjPrivate *priv = vm->privateData;
virDomainIOThreadInfo **iothreads = NULL;
size_t i;
size_t niothreads;
int niothreads;
if ((niothreads = virCHMonitorGetIOThreads(priv->monitor, &iothreads)) < 0)
return -1;
niothreads = virCHMonitorGetIOThreads(priv->monitor, &iothreads);
for (i = 0; i < niothreads; i++) {
VIR_DEBUG("IOThread index = %ld , tid = %d", i, iothreads[i]->iothread_id);
if (virCHProcessSetupIOThread(vm, iothreads[i]) < 0)