External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 11:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

virHostCPUGetStatsLinux: Avoid 'strcpy'

Browse Source 
Use an allocated buffer for 'cpu_header' so that g_strdup(_printf) can
be used to fill it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2021-03-03 11:14:33 +01:00
parent 14a4f7cbf2
commit 4851a99ee0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/util/virhostcpu.c
View File

@ -787,7 +787,7 @@ virHostCPUGetStatsLinux(FILE *procstat,
char line[1024]; char line[1024];
unsigned long long usr, ni, sys, idle, iowait; unsigned long long usr, ni, sys, idle, iowait;
unsigned long long irq, softirq, steal, guest, guest_nice; unsigned long long irq, softirq, steal, guest, guest_nice;
char cpu_header[4 + VIR_INT64_STR_BUFLEN]; g_autofree char *cpu_header = NULL;
if ((*nparams) == 0) { if ((*nparams) == 0) {
/* Current number of cpu stats supported by linux */ /* Current number of cpu stats supported by linux */
@ -803,9 +803,9 @@ virHostCPUGetStatsLinux(FILE *procstat,
} }
if (cpuNum == VIR_NODE_CPU_STATS_ALL_CPUS) { if (cpuNum == VIR_NODE_CPU_STATS_ALL_CPUS) {
strcpy(cpu_header, "cpu "); cpu_header = g_strdup("cpu ");
} else { } else {
g_snprintf(cpu_header, sizeof(cpu_header), "cpu%d ", cpuNum); cpu_header = g_strdup_printf("cpu%d ", cpuNum);
} }
while (fgets(line, sizeof(line), procstat) != NULL) { while (fgets(line, sizeof(line), procstat) != NULL) {