External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 07:59:00 +00:00
Code

storage_backend_fs: Allocate entry for host before accessing it

Browse Source 
Commit 122fa379de44a2fd0a6d5fbcb634535d647ada17 introduces option to
store more than one host entry in a storage pool source definition. That
commit causes a regression, where a check is added that only one host
entry should be present (that actualy is not present as the source
structure was just allocated and zeroed) instead of allocating memory
for the host entry.
This commit is contained in:
Peter Krempa 2012-07-09 14:37:01 +02:00
parent ab9c72ae9e
commit 48b7851998
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/storage/storage_backend_fs.c
View File

@ -205,11 +205,11 @@ virStorageBackendFileSystemNetFindPoolSourcesFunc(virStoragePoolObjPtr pool ATTR
if (!(src = virStoragePoolSourceListNewSource(&state->list)))
goto cleanup;
if (src->nhost != 1) {
virStorageReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("Expected exactly 1 host for the storage pool"));
if (VIR_ALLOC_N(src->hosts, 1) < 0) {
virReportOOMError();
goto cleanup;
}
src->nhost = 1;
if (!(src->hosts[0].name = strdup(state->host)) ||
!(src->dir = strdup(path))) {