External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 12:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: minor comment/formatting changes to virNetDevTapCreate()

Browse Source 
The comment about auto-generating names was obsoleted by recent
changes, and there was an unnecessary set of braces around a single
line conditional body.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Laine Stump 2020-12-15 15:14:45 -05:00
parent b36569ec77
commit 4974872abc
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/util/virnetdevtap.c
View File

@ -174,15 +174,14 @@ int virNetDevTapCreate(char **ifname,
int ret = -1; int ret = -1;
int fd = -1; int fd = -1;
/* if ifname is "vnet%d", then auto-generate a name for the new /* if ifname is empty, then auto-generate a name for the new
* device (the kernel could do this for us, but has a bad habit of * device (the kernel could do this for us, but has a bad habit of
* immediately re-using names that have just been released, which * immediately re-using names that have just been released, which
* can lead to race conditions). * can lead to race conditions). if ifname is just a
* if ifname is just a user-provided name, virNetDevGenerateName * user-provided name, virNetDevGenerateName leaves it
* leaves it unchanged. */ * unchanged. */
if (virNetDevGenerateName(ifname, VIR_NET_DEV_GEN_NAME_VNET) < 0) { if (virNetDevGenerateName(ifname, VIR_NET_DEV_GEN_NAME_VNET) < 0)
return -1; return -1;
}
if (!tunpath) if (!tunpath)
tunpath = "/dev/net/tun"; tunpath = "/dev/net/tun";