External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-11 15:27:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: xml: Remove VIR_XML_PROP_WRAPNEGATIVE

Browse Source 
As I've pointed out in my review, the negative number wrapping for
unsigned variables is an anti-feature which should not be promoted in
any way.

Remove VIR_XML_PROP_WRAPNEGATIVE which would make it more accessible.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2021-04-21 08:41:00 +02:00
parent 25af3e6ceb
commit 497c3ecd78
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/util/virxml.c
View File

@ -734,11 +734,7 @@ virXMLPropUInt(xmlNodePtr node,
return -1;
}
if (flags & VIR_XML_PROP_WRAPNEGATIVE) {
ret = virStrToLong_ui(tmp, NULL, base, &val);
} else {
ret = virStrToLong_uip(tmp, NULL, base, &val);
}
ret = virStrToLong_uip(tmp, NULL, base, &val);
if (ret < 0) {
virReportError(VIR_ERR_XML_ERROR,

1
src/util/virxml.h
View File

@ -38,7 +38,6 @@ typedef enum {
VIR_XML_PROP_OPTIONAL = 0, /* Attribute may be absent */
VIR_XML_PROP_REQUIRED = 1 << 0, /* Attribute may not be absent */
VIR_XML_PROP_NONZERO = 1 << 1, /* Attribute may not be zero */
VIR_XML_PROP_WRAPNEGATIVE = 1 << 2, /* Wrap around negative values */
} virXMLPropFlags;