From 49f199f3fdd50a35333148c75bf425dc6e76d930 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Mon, 4 Oct 2021 18:04:12 +0200 Subject: [PATCH] qemu: command: Remove unused qemuBuildRomStr MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Now that all users were converted to qemuBuildRomProps we can remove the old code and un-mark qemuBuildRomProps as unused. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_command.c | 34 +--------------------------------- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 11751b31e2..5e7d9e9d08 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1271,7 +1271,7 @@ qemuBuildVirtioDevStr(virBuffer *buf, } -static int G_GNUC_UNUSED +static int qemuBuildRomProps(virJSONValue *props, virDomainDeviceInfo *info) { @@ -1311,38 +1311,6 @@ qemuBuildRomProps(virJSONValue *props, } -static int G_GNUC_UNUSED -qemuBuildRomStr(virBuffer *buf, - virDomainDeviceInfo *info) -{ - if (info->romenabled || info->rombar || info->romfile) { - /* Passing an empty romfile= tells QEMU to disable ROM entirely for - * this device, and makes other settings irrelevant */ - if (info->romenabled == VIR_TRISTATE_BOOL_NO) { - virBufferAddLit(buf, ",romfile="); - return 0; - } - - switch (info->rombar) { - case VIR_TRISTATE_SWITCH_OFF: - virBufferAddLit(buf, ",rombar=0"); - break; - case VIR_TRISTATE_SWITCH_ON: - virBufferAddLit(buf, ",rombar=1"); - break; - case VIR_TRISTATE_SWITCH_ABSENT: - case VIR_TRISTATE_SWITCH_LAST: - break; - } - if (info->romfile) { - virBufferAddLit(buf, ",romfile="); - virQEMUBuildBufferEscapeComma(buf, info->romfile); - } - } - - return 0; -} - static int qemuBuildIoEventFdStr(virBuffer *buf, virTristateSwitch use,