mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 21:55:25 +00:00
virsh: Reset global error after successfull domain lookup
When looking up a domain, we try to look up by ID, UUID and NAME
consequently while not really caring which of those lookups succeeds.
The problem is that if any of them fails, we dispatch the error from the
driver and that means setting both threadlocal and global error. Let's
say the last lookup (by NAME) succeeds and resets the threadlocal error as any
other API does, however leaving the global error unchanged. If the underlying
virsh command does not succeed afterwards, our cleanup routine in
vshCommandRun ensures that no libvirt error will be forgotten and that's
exactly where this global error comes in incorrectly.
# virsh domif-setlink 123 vnet1 up
error: interface (target: vnet1) not found
error: Domain not found: no domain with matching id 123
This patch also resets the global error which would otherwise cause some
minor confusion in reported error messages.
https://bugzilla.redhat.com/show_bug.cgi?id=1254152
Signed-off-by: Luyao Huang <lhuang@redhat.com>
Signed-off-by: Erik Skultety <eskultet@redhat.com>
(cherry picked from commit 70f56dd72c
)
This commit is contained in:
parent
9e5c5fbdc6
commit
4a3bd30e50
@ -97,6 +97,8 @@ vshLookupDomainInternal(vshControl *ctl,
|
|||||||
dom = virDomainLookupByName(ctl->conn, name);
|
dom = virDomainLookupByName(ctl->conn, name);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
vshResetLibvirtError();
|
||||||
|
|
||||||
if (!dom)
|
if (!dom)
|
||||||
vshError(ctl, _("failed to get domain '%s'"), name);
|
vshError(ctl, _("failed to get domain '%s'"), name);
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user