External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-24 12:22:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu_namespace: Fix detection of nested mount points

Browse Source 
When deciding whether to bind mount a path in domain's namespace,
we look at the QEMU mount table (/proc/$pid/mounts) and try to
match prefix of given path with one of mount points. Well, we
do that in a bit clumsy way. For instance, if there's
"/dev/hugepages" already mounted inside the namespace and we are
deciding whether to bind mount "/dev/hugepages1G/..." we decide
to skip over the path and NOT bind mount it. This is because
plain STRPREFIX() is used and yes, the former is prefix of the
latter. What we need to check also is whether the next character
after the prefix is slash.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Michal Privoznik 2023-01-03 15:51:42 +01:00
parent 379c0ce4bf
commit 4a91324b61
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/qemu/qemu_namespace.c
View File

@ -1264,9 +1264,11 @@ qemuNamespacePrepareOneItem(qemuNamespaceMknodData *data,
bool found = false; bool found = false;
for (n = devMountsPath; n && *n; n++) { for (n = devMountsPath; n && *n; n++) {
const char *p;
if (STREQ(*n, "/dev")) if (STREQ(*n, "/dev"))
continue; continue;
if (STRPREFIX(item.file, *n)) { if ((p = STRSKIP(item.file, *n)) && *p == '/') {
found = true; found = true;
break; break;
} }