External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virDomainDiskDefValidateSourceChainOne: Reject authentication for protocols which don't support it

Browse Source 
Only certain disk protocols support authentication. Add validation for
this field.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2022-04-22 16:59:37 +02:00
parent b1f5f14a5c
commit 4c6498d48a
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/conf/domain_validate.c
View File

@ -473,10 +473,44 @@ virDomainDiskVhostUserValidate(const virDomainDiskDef *disk)
static int static int
virDomainDiskDefValidateSourceChainOne(const virStorageSource *src) virDomainDiskDefValidateSourceChainOne(const virStorageSource *src)
{ {
virStorageType actualType = virStorageSourceGetActualType(src);
if (src->type == VIR_STORAGE_TYPE_NETWORK && src->auth) { if (src->type == VIR_STORAGE_TYPE_NETWORK && src->auth) {
virStorageAuthDef *authdef = src->auth; virStorageAuthDef *authdef = src->auth;
int actUsage; int actUsage;
if (actualType != VIR_STORAGE_TYPE_NETWORK) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("authentication is supported only for network backed disks"));
return -1;
}
switch ((virStorageNetProtocol) src->protocol) {
case VIR_STORAGE_NET_PROTOCOL_ISCSI:
case VIR_STORAGE_NET_PROTOCOL_HTTP:
case VIR_STORAGE_NET_PROTOCOL_HTTPS:
case VIR_STORAGE_NET_PROTOCOL_FTP:
case VIR_STORAGE_NET_PROTOCOL_FTPS:
case VIR_STORAGE_NET_PROTOCOL_SSH:
case VIR_STORAGE_NET_PROTOCOL_RBD:
break;
case VIR_STORAGE_NET_PROTOCOL_NBD:
case VIR_STORAGE_NET_PROTOCOL_SHEEPDOG:
case VIR_STORAGE_NET_PROTOCOL_GLUSTER:
case VIR_STORAGE_NET_PROTOCOL_TFTP:
case VIR_STORAGE_NET_PROTOCOL_VXHS:
case VIR_STORAGE_NET_PROTOCOL_NFS:
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("authentication is not supported for protocol '%s'"),
virStorageNetProtocolTypeToString(src->protocol));
return -1;
case VIR_STORAGE_NET_PROTOCOL_NONE:
case VIR_STORAGE_NET_PROTOCOL_LAST:
break;
}
if ((actUsage = virSecretUsageTypeFromString(authdef->secrettype)) < 0) { if ((actUsage = virSecretUsageTypeFromString(authdef->secrettype)) < 0) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("unknown secret type '%s'"), _("unknown secret type '%s'"),