External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-03 04:45:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

nwfilter: prevent filters with different name but same UUID

Browse Source 
Patch to prevent multiple nwfilters with different name but same UUID.
This commit is contained in:
Stefan Berger 2010-10-14 11:53:08 -04:00
parent a33b7b6f35
commit 4cfcde2d83
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/conf/nwfilter_conf.c
View File

@ -2399,6 +2399,20 @@ virNWFilterPoolObjAssignDef(virConnectPtr conn,
{ {
virNWFilterPoolObjPtr pool; virNWFilterPoolObjPtr pool;
pool = virNWFilterPoolObjFindByUUID(pools, def->uuid);
if (pool) {
if (!STREQ(def->name, pool->def->name)) {
virNWFilterReportError(VIR_ERR_INVALID_NWFILTER,
_("filter with same UUID but different name "
"('%s') already exists"),
pool->def->name);
virNWFilterPoolObjUnlock(pool);
return NULL;
}
virNWFilterPoolObjUnlock(pool);
}
if (virNWFilterDefLoopDetect(conn, pools, def)) { if (virNWFilterDefLoopDetect(conn, pools, def)) {
virNWFilterReportError(VIR_ERR_INVALID_NWFILTER, virNWFilterReportError(VIR_ERR_INVALID_NWFILTER,
"%s", _("filter would introduce a loop")); "%s", _("filter would introduce a loop"));