External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-08 05:55:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix vPort management: FC vHBA creation

Browse Source 
When creating a virtual FC HBA with virsh/libvirt API, an error message
will be returned: "error: Node device not found",
also the 'nodedev-dumpxml' shows wrong information of wwpn & wwnn
for the new created device.

Signed-off-by: xschen@tnsoft.com.cn

This reverts f90af69 which switched wwpn & wwwn in the wrong place.

https://www.kernel.org/doc/Documentation/scsi/scsi_fc_transport.txt
(cherry picked from commit 3c0d5e224c)
This commit is contained in:
Dennis Chen 2013-06-28 11:59:51 +02:00 committed by Ján Tomko
parent 0347e778ca
commit 4d21d84532
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/storage/storage_backend_scsi.c
View File

@ -671,8 +671,8 @@ createVport(virStoragePoolSourceAdapter adapter)
if (getHostNumber(adapter.data.fchost.parent, &parent_host) < 0) if (getHostNumber(adapter.data.fchost.parent, &parent_host) < 0)
return -1; return -1;
if (virManageVport(parent_host, adapter.data.fchost.wwnn, if (virManageVport(parent_host, adapter.data.fchost.wwpn,
adapter.data.fchost.wwpn, VPORT_CREATE) < 0) adapter.data.fchost.wwnn, VPORT_CREATE) < 0)
return -1; return -1;
virFileWaitForDevices(); virFileWaitForDevices();
@ -694,8 +694,8 @@ deleteVport(virStoragePoolSourceAdapter adapter)
if (getHostNumber(adapter.data.fchost.parent, &parent_host) < 0) if (getHostNumber(adapter.data.fchost.parent, &parent_host) < 0)
return -1; return -1;
if (virManageVport(parent_host, adapter.data.fchost.wwnn, if (virManageVport(parent_host, adapter.data.fchost.wwpn,
adapter.data.fchost.wwpn, VPORT_DELETE) < 0) adapter.data.fchost.wwnn, VPORT_DELETE) < 0)
return -1; return -1;
return 0; return 0;

4
src/util/virutil.c
View File

@ -3559,8 +3559,8 @@ virManageVport(const int parent_host,
if (virAsprintf(&vport_name, if (virAsprintf(&vport_name,
"%s:%s", "%s:%s",
wwnn, wwpn,
wwpn) < 0) { wwnn) < 0) {
virReportOOMError(); virReportOOMError();
goto cleanup; goto cleanup;
} }