External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 21:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

libvirt-guests: Wait for libvirtd to initialize

Browse Source 
I've noticed that in some cases systemd was quick enough and even
if libvirt-guests.service is marked to be started after the
libvirtd.service my guests were not resumed as
libvirt-guests.sh failed to connect. This is because of a
simple fact: systemd correctly starts libvirt-guests after it
execs libvirtd. However, the daemon is not able to accept
connections right from the start. It's doing some
initialization which may take ages. This problem is not limited
to systemd only, indeed. Any init system that is able to startup
services in parallel (e.g. OpenRC) may run into this situation.
The fix is to try connecting not only once, but continuously a few
times with a small sleep in between tries.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2014-02-21 12:46:08 +01:00
parent ba79e3879e
commit 4e7fc8305a
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/libvirt-guests.sh.in
View File

@ -37,6 +37,8 @@ SHUTDOWN_TIMEOUT=300
PARALLEL_SHUTDOWN=0 PARALLEL_SHUTDOWN=0
START_DELAY=0 START_DELAY=0
BYPASS_CACHE=0 BYPASS_CACHE=0
CONNECT_RETRIES=10
RETRIES_SLEEP=1
test -f "$sysconfdir"/sysconfig/libvirt-guests && test -f "$sysconfdir"/sysconfig/libvirt-guests &&
. "$sysconfdir"/sysconfig/libvirt-guests . "$sysconfdir"/sysconfig/libvirt-guests
@ -87,12 +89,17 @@ test_connect()
{ {
uri=$1 uri=$1
for ((i = 0; i < ${CONNECT_RETRIES}; i++)); do
run_virsh "$uri" connect 2>/dev/null run_virsh "$uri" connect 2>/dev/null
if [ $? -ne 0 ]; then if [ $? -eq 0 ]; then
return 0;
fi
sleep ${RETRIES_SLEEP}
eval_gettext "Unable to connect to libvirt currently. Retrying .. \$i"
done
eval_gettext "Can't connect to \$uri. Skipping." eval_gettext "Can't connect to \$uri. Skipping."
echo echo
return 1 return 1
fi
} }
# list_guests URI PERSISTENT # list_guests URI PERSISTENT