External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 11:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

zfs: Resolve RESOURCE_LEAK

Browse Source 
Found by my Coverity checker - virCheckFlags call could return -1, but
not virCommandFree(destroy_cmd).

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2016-02-19 13:54:45 -05:00
parent fe0063685a
commit 4e87164306
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/storage/storage_backend_zfs.c
View File

@ -355,10 +355,12 @@ virStorageBackendZFSDeleteVol(virConnectPtr conn ATTRIBUTE_UNUSED,
unsigned int flags) unsigned int flags)
{ {
int ret = -1; int ret = -1;
virCommandPtr destroy_cmd = virCommandNewArgList(ZFS, "destroy", NULL); virCommandPtr destroy_cmd = NULL;
virCheckFlags(0, -1); virCheckFlags(0, -1);
destroy_cmd = virCommandNewArgList(ZFS, "destroy", NULL);
virCommandAddArgFormat(destroy_cmd, "%s/%s", virCommandAddArgFormat(destroy_cmd, "%s/%s",
pool->def->source.name, vol->name); pool->def->source.name, vol->name);