External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virDomainResctrlMonDefParse: Use virXMLProp*

Browse Source 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Tim Wiederhake 2021-05-04 16:02:35 +02:00 committed by Michal Privoznik
parent d897ae3cb4
commit 4ef4476d3a
1 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/conf/domain_conf.c
View File

@ -18580,19 +18580,9 @@ virDomainResctrlMonDefParse(virDomainDef *def,
} }
if (tag == VIR_RESCTRL_MONITOR_TYPE_CACHE) { if (tag == VIR_RESCTRL_MONITOR_TYPE_CACHE) {
tmp = virXMLPropString(nodes[i], "level"); if (virXMLPropUInt(nodes[i], "level", 10, VIR_XML_PROP_REQUIRED,
if (!tmp) { &level) < 0)
virReportError(VIR_ERR_XML_ERROR, "%s",
_("Missing monitor attribute 'level'"));
goto cleanup; goto cleanup;
}
if (virStrToLong_uip(tmp, NULL, 10, &level) < 0) {
virReportError(VIR_ERR_XML_ERROR,
_("Invalid monitor attribute 'level' value '%s'"),
tmp);
goto cleanup;
}
if (level != VIR_DOMAIN_RESCTRL_MONITOR_CACHELEVEL) { if (level != VIR_DOMAIN_RESCTRL_MONITOR_CACHELEVEL) {
virReportError(VIR_ERR_XML_ERROR, virReportError(VIR_ERR_XML_ERROR,
@ -18600,8 +18590,6 @@ virDomainResctrlMonDefParse(virDomainDef *def,
level); level);
goto cleanup; goto cleanup;
} }
VIR_FREE(tmp);
} }
if (virDomainResctrlParseVcpus(def, nodes[i], &domresmon->vcpus) < 0) if (virDomainResctrlParseVcpus(def, nodes[i], &domresmon->vcpus) < 0)