External/libvirt
1
0
Fork 0
Code

Fix virLXCPrepareHostDevices method

Browse Source 
The virLXCPrepareHostDevices method was returning success even
when it reported an error, and failed to handle several host
device types
This commit is contained in:
Daniel P. Berrange 2013-01-07 18:16:54 +00:00
parent f0e4af91e4
commit 4f1f9d91ab
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/lxc/lxc_hostdev.c
View File

@ -299,15 +299,29 @@ int virLXCPrepareHostDevices(virLXCDriverPtr driver,
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("Unsupported hostdev type %s"), _("Unsupported hostdev type %s"),
virDomainHostdevSubsysTypeToString(dev->source.subsys.type)); virDomainHostdevSubsysTypeToString(dev->source.subsys.type));
break; return -1;
} }
break; break;
case VIR_DOMAIN_HOSTDEV_MODE_CAPABILITIES:
switch (dev->source.subsys.type) {
case VIR_DOMAIN_HOSTDEV_CAPS_TYPE_STORAGE:
case VIR_DOMAIN_HOSTDEV_CAPS_TYPE_MISC:
break;
default:
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("Unsupported hostdev type %s"),
virDomainHostdevSubsysTypeToString(dev->source.subsys.type));
return -1;
}
break;
default: default:
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("Unsupported hostdev mode %s"), _("Unsupported hostdev mode %s"),
virDomainHostdevModeTypeToString(dev->mode)); virDomainHostdevModeTypeToString(dev->mode));
break; return -1;
} }
} }