External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-18 18:45:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

daemon: Resolve Coverity NEGATIVE_RETURNS

Browse Source 
In each of these cases, Coverity complains that the result count returned
on error paths would be -1 disregarding that the count and the corresponding
are "linked" together (it doesn't know that).  Simple enough to check and
remove the warning
This commit is contained in:
John Ferlan 2014-08-27 13:38:29 -04:00
parent 5e54297073
commit 4f25146bf4
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
daemon/remote.c
View File

@ -1535,7 +1535,7 @@ remoteDispatchConnectListAllDomains(virNetServerPtr server ATTRIBUTE_UNUSED,
cleanup: cleanup:
if (rv < 0) if (rv < 0)
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (doms) { if (doms && ndomains > 0) {
for (i = 0; i < ndomains; i++) for (i = 0; i < ndomains; i++)
virDomainFree(doms[i]); virDomainFree(doms[i]);
VIR_FREE(doms); VIR_FREE(doms);
@ -4632,7 +4632,7 @@ remoteDispatchDomainGetDiskErrors(virNetServerPtr server ATTRIBUTE_UNUSED,
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (dom) if (dom)
virDomainFree(dom); virDomainFree(dom);
if (errors) { if (errors && len > 0) {
size_t i; size_t i;
for (i = 0; i < len; i++) for (i = 0; i < len; i++)
VIR_FREE(errors[i].disk); VIR_FREE(errors[i].disk);
@ -4698,7 +4698,7 @@ remoteDispatchDomainListAllSnapshots(virNetServerPtr server ATTRIBUTE_UNUSED,
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (dom) if (dom)
virDomainFree(dom); virDomainFree(dom);
if (snaps) { if (snaps && nsnaps > 0) {
for (i = 0; i < nsnaps; i++) for (i = 0; i < nsnaps; i++)
virDomainSnapshotFree(snaps[i]); virDomainSnapshotFree(snaps[i]);
VIR_FREE(snaps); VIR_FREE(snaps);
@ -4769,7 +4769,7 @@ remoteDispatchDomainSnapshotListAllChildren(virNetServerPtr server ATTRIBUTE_UNU
virDomainSnapshotFree(snapshot); virDomainSnapshotFree(snapshot);
if (dom) if (dom)
virDomainFree(dom); virDomainFree(dom);
if (snaps) { if (snaps && nsnaps > 0) {
for (i = 0; i < nsnaps; i++) for (i = 0; i < nsnaps; i++)
virDomainSnapshotFree(snaps[i]); virDomainSnapshotFree(snaps[i]);
VIR_FREE(snaps); VIR_FREE(snaps);
@ -4828,7 +4828,7 @@ remoteDispatchConnectListAllStoragePools(virNetServerPtr server ATTRIBUTE_UNUSED
cleanup: cleanup:
if (rv < 0) if (rv < 0)
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (pools) { if (pools && npools > 0) {
for (i = 0; i < npools; i++) for (i = 0; i < npools; i++)
virStoragePoolFree(pools[i]); virStoragePoolFree(pools[i]);
VIR_FREE(pools); VIR_FREE(pools);
@ -4891,7 +4891,7 @@ remoteDispatchStoragePoolListAllVolumes(virNetServerPtr server ATTRIBUTE_UNUSED,
cleanup: cleanup:
if (rv < 0) if (rv < 0)
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (vols) { if (vols && nvols > 0) {
for (i = 0; i < nvols; i++) for (i = 0; i < nvols; i++)
virStorageVolFree(vols[i]); virStorageVolFree(vols[i]);
VIR_FREE(vols); VIR_FREE(vols);
@ -4952,7 +4952,7 @@ remoteDispatchConnectListAllNetworks(virNetServerPtr server ATTRIBUTE_UNUSED,
cleanup: cleanup:
if (rv < 0) if (rv < 0)
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (nets) { if (nets && nnets > 0) {
for (i = 0; i < nnets; i++) for (i = 0; i < nnets; i++)
virNetworkFree(nets[i]); virNetworkFree(nets[i]);
VIR_FREE(nets); VIR_FREE(nets);
@ -5011,7 +5011,7 @@ remoteDispatchConnectListAllInterfaces(virNetServerPtr server ATTRIBUTE_UNUSED,
cleanup: cleanup:
if (rv < 0) if (rv < 0)
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (ifaces) { if (ifaces && nifaces > 0) {
for (i = 0; i < nifaces; i++) for (i = 0; i < nifaces; i++)
virInterfaceFree(ifaces[i]); virInterfaceFree(ifaces[i]);
VIR_FREE(ifaces); VIR_FREE(ifaces);
@ -5070,7 +5070,7 @@ remoteDispatchConnectListAllNodeDevices(virNetServerPtr server ATTRIBUTE_UNUSED,
cleanup: cleanup:
if (rv < 0) if (rv < 0)
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (devices) { if (devices && ndevices > 0) {
for (i = 0; i < ndevices; i++) for (i = 0; i < ndevices; i++)
virNodeDeviceFree(devices[i]); virNodeDeviceFree(devices[i]);
VIR_FREE(devices); VIR_FREE(devices);
@ -5129,7 +5129,7 @@ remoteDispatchConnectListAllNWFilters(virNetServerPtr server ATTRIBUTE_UNUSED,
cleanup: cleanup:
if (rv < 0) if (rv < 0)
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (filters) { if (filters && nfilters > 0) {
for (i = 0; i < nfilters; i++) for (i = 0; i < nfilters; i++)
virNWFilterFree(filters[i]); virNWFilterFree(filters[i]);
VIR_FREE(filters); VIR_FREE(filters);
@ -5188,7 +5188,7 @@ remoteDispatchConnectListAllSecrets(virNetServerPtr server ATTRIBUTE_UNUSED,
cleanup: cleanup:
if (rv < 0) if (rv < 0)
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (secrets) { if (secrets && nsecrets > 0) {
for (i = 0; i < nsecrets; i++) for (i = 0; i < nsecrets; i++)
virSecretFree(secrets[i]); virSecretFree(secrets[i]);
VIR_FREE(secrets); VIR_FREE(secrets);
@ -6373,7 +6373,7 @@ remoteDispatchNetworkGetDHCPLeases(virNetServerPtr server ATTRIBUTE_UNUSED,
cleanup: cleanup:
if (rv < 0) if (rv < 0)
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (leases) { if (leases && nleases > 0) {
for (i = 0; i < nleases; i++) for (i = 0; i < nleases; i++)
virNetworkDHCPLeaseFree(leases[i]); virNetworkDHCPLeaseFree(leases[i]);
VIR_FREE(leases); VIR_FREE(leases);