External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-11 15:27:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use virGetLastErrorMessage to avoid Coverity message

Browse Source 
Both instances use VIR_WARN() to print the error from a failed
virDBusGetSystemBus() call.  Rather than use the virGetLastError
and need to check for valid return err pointer, just use the
virGetLastErrorMessage.

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2016-05-05 18:27:00 -04:00
parent f0187c1f27
commit 4fac5a9fd3
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/network/bridge_driver.c
View File

@ -695,9 +695,8 @@ networkStateInitialize(bool privileged,
#ifdef HAVE_FIREWALLD #ifdef HAVE_FIREWALLD
if (!(sysbus = virDBusGetSystemBus())) { if (!(sysbus = virDBusGetSystemBus())) {
virErrorPtr err = virGetLastError();
VIR_WARN("DBus not available, disabling firewalld support " VIR_WARN("DBus not available, disabling firewalld support "
"in bridge_network_driver: %s", err->message); "in bridge_network_driver: %s", virGetLastErrorMessage());
} else { } else {
/* add matches for /* add matches for
* NameOwnerChanged on org.freedesktop.DBus for firewalld start/stop * NameOwnerChanged on org.freedesktop.DBus for firewalld start/stop

3
src/node_device/node_device_hal.c
View File

@ -641,9 +641,8 @@ nodeStateInitialize(bool privileged ATTRIBUTE_UNUSED,
dbus_error_init(&err); dbus_error_init(&err);
if (!(sysbus = virDBusGetSystemBus())) { if (!(sysbus = virDBusGetSystemBus())) {
virErrorPtr verr = virGetLastError();
VIR_ERROR(_("DBus not available, disabling HAL driver: %s"), VIR_ERROR(_("DBus not available, disabling HAL driver: %s"),
verr->message); virGetLastErrorMessage());
ret = 0; ret = 0;
goto failure; goto failure;
} }