From 50129dcc9cb1caa312606c86b62431c643b8f39b Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Thu, 25 Feb 2016 08:44:46 +0100 Subject: [PATCH] vircgroupmock: Mock access("/sys/devices/system/cpu/present") There's been a report on the upstream list [1] describing we access /sys/devices/system/cpu/present directly on the host from within our test suite. This may end up in unpredictable results as no all linux systems are required to have that file. Mock access to the file. libvirt.git/tests $ ../run strace vircgrouptest ... access("/sys/devices/system/cpu/present", F_OK) = 0 ... Signed-off-by: Michal Privoznik --- tests/vircgroupmock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/vircgroupmock.c b/tests/vircgroupmock.c index 9ce7d41cad..756ac51679 100644 --- a/tests/vircgroupmock.c +++ b/tests/vircgroupmock.c @@ -541,7 +541,8 @@ int access(const char *path, int mode) ret = realaccess(newpath, mode); free(newpath); } else if (STREQ(path, "/proc/cgroups") || - STREQ(path, "/proc/self/cgroup")) { + STREQ(path, "/proc/self/cgroup") || + STREQ(path, SYSFS_CPU_PRESENT)) { /* These files are readable for all. */ ret = (mode == F_OK || mode == R_OK) ? 0 : -1; } else if (STREQ(path, "/proc/mounts")) {