External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh-interface: Resolve Coverity issues

Browse Source 
Recent changes uncovered FORWARD_NULL and NEGATIVE_RETURNS problems with
the processing of the 'nActiveIfaces' and 'nInactiveIfaces' and their
associated allocated arrays in 'vshInterfaceListCollect' due to the
possibility of returning -1 in a call and using the return value as a
for loop index end condition.
This commit is contained in:
John Ferlan 2013-07-11 10:31:15 -04:00
parent 0cfd40ac0c
commit 50210ab9ff
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/virsh-interface.c
View File

@ -300,10 +300,10 @@ finished:
success = true; success = true;
cleanup: cleanup:
for (i = 0; i < nActiveIfaces; i++) for (i = 0; nActiveIfaces != -1 && i < nActiveIfaces; i++)
VIR_FREE(activeNames[i]); VIR_FREE(activeNames[i]);
for (i = 0; i < nInactiveIfaces; i++) for (i = 0; nInactiveIfaces != -1 && i < nInactiveIfaces; i++)
VIR_FREE(inactiveNames[i]); VIR_FREE(inactiveNames[i]);
VIR_FREE(activeNames); VIR_FREE(activeNames);