mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-30 09:53:10 +00:00
snapshot: require user to supply external memory file name
For disk snapshots, the user could request an external snapshot but not supply a filename; later on, we would check this condition and generate a suitable name if possible, or gracefully error out when not possible (such as when the original file was a block device). But unless we come up with a suitable way to generate external memory file names, we have no later code point that was checking for NULL, so we should forbid this up front. * src/conf/snapshot_conf.c (virDomainSnapshotDefParseString): Avoid NULL deref, since we don't generate names yet.
This commit is contained in:
parent
63158d586b
commit
516c12237b
@ -293,6 +293,12 @@ virDomainSnapshotDefParseString(const char *xmlStr,
|
||||
memoryFile);
|
||||
goto cleanup;
|
||||
}
|
||||
if (!memoryFile &&
|
||||
def->memory == VIR_DOMAIN_SNAPSHOT_LOCATION_EXTERNAL) {
|
||||
virReportError(VIR_ERR_XML_ERROR, "%s",
|
||||
_("external memory snapshots require a filename"));
|
||||
goto cleanup;
|
||||
}
|
||||
} else if (memoryFile) {
|
||||
def->memory = VIR_DOMAIN_SNAPSHOT_LOCATION_EXTERNAL;
|
||||
} else if (flags & VIR_DOMAIN_SNAPSHOT_PARSE_REDEFINE) {
|
||||
|
Loading…
Reference in New Issue
Block a user